Reviewing an iOS PR
A take-home asks you to review an existing PR and leave comments. When you review an iOS PR, what do you look at and in what order?
A take-home asks you to review an existing PR and leave comments. When you review an iOS PR, what do you look at and in what order?
First read the PR description and the intent of the change, then go correctness (boundaries, errors, concurrency, retain cycles) → whether tests exist and are any good → design and dependency direction → performance and memory → style. Leave style to the linter and spend human attention on correctness.
TestingShort answerBasics
You got a take-home for a minimal iOS app with basic unit tests, and the brief says to…
#take-home
TestingShort answerBasics
This is a written question on a take-home: "how do you integrate tests into your…
#pull-request
TestingShort answerBasics
A PR fixing a bug in a beauty appointment app got a review comment saying there's no…
#code-review
TestingShort answerBasics
You're adding automated tests to the listing feature of a secondhand marketplace app for…
#quality