Daily iOS
Testing

Reviewing an iOS PR

A take-home asks you to review an existing PR and leave comments. When you review an iOS PR, what do you look at and in what order?

How would an interviewer hear this answer? You'll see whether they'd move on, dig in, or say no, and which sentences would trip you up. Your score doesn't change.
See the short answer

First read the PR description and the intent of the change, then go correctness (boundaries, errors, concurrency, retain cycles) → whether tests exist and are any good → design and dependency direction → performance and memory → style. Leave style to the linter and spend human attention on correctness.

Share a question